From bc9c35631e1784c06e1bb2302358c81397d6eddf Mon Sep 17 00:00:00 2001 From: lorenzg Date: Thu, 19 Nov 2026 15:01:13 +0100 Subject: [PATCH 1/5] fix defaults to match packaging/snclient.ini --- pkg/snclient/check_logfile.go | 2 +- pkg/snclient/config.go | 4 ++-- pkg/snclient/listen_exporterexporter.go | 7 ++++--- pkg/snclient/listen_prometheus.go | 2 +- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/pkg/snclient/check_logfile.go b/pkg/snclient/check_logfile.go index 873556737..1792d8c3b 100644 --- a/pkg/snclient/check_logfile.go +++ b/pkg/snclient/check_logfile.go @@ -24,7 +24,7 @@ const ( defaultMaxLinesPerFile = 10000 // maxLinesPerFileMax sets the upper limit a user can request by args (can be increased from the config) - maxLinesPerFileMax = 100000 + maxLinesPerFileMax = 1000000 ) var numReg = regexp.MustCompile(`\d+`) diff --git a/pkg/snclient/config.go b/pkg/snclient/config.go index fa1f52258..d5c371afa 100644 --- a/pkg/snclient/config.go +++ b/pkg/snclient/config.go @@ -49,7 +49,7 @@ var DefaultConfig = map[string]ConfigData{ "CheckSystemUnix": "enabled", "CheckAlias": "enabled", "CheckMulti": "enabled", - "CheckExternalScripts": "enabled", + "CheckExternalScripts": "disabled", "CheckDisk": "enabled", "CheckDriveIO": "enabled", "CheckSwapIO": "enabled", @@ -84,7 +84,7 @@ var DefaultConfig = map[string]ConfigData{ "ignore perfdata": "false", }, "/settings/external scripts/wrappings": { - "bat": `${scripts}\%SCRIPT% %ARGS%`, + "bat": `${script root}\%SCRIPT% %ARGS%`, "ps1": `cmd /c echo ` + `If (-Not (Test-Path "${script root}\%SCRIPT%") ) ` + `{ Write-Host "UNKNOWN: Script ` + "`\"%SCRIPT%`\" not found.\"; exit(3) }; " + diff --git a/pkg/snclient/listen_exporterexporter.go b/pkg/snclient/listen_exporterexporter.go index 6d3fd5cc2..84f00cbf6 100644 --- a/pkg/snclient/listen_exporterexporter.go +++ b/pkg/snclient/listen_exporterexporter.go @@ -34,9 +34,10 @@ func init() { NewHandlerExporterExporter, ConfigInit{ ConfigData{ - "port": "${/settings/WEB/server/port}", - "use ssl": "${/settings/WEB/server/use ssl}", - "url prefix": "/", + "port": "${/settings/WEB/server/port}", + "use ssl": "${/settings/WEB/server/use ssl}", + "url prefix": "/", + "modules dir": "${shared-path}/exporter_modules", }, "/settings/default", DefaultListenHTTPConfig, diff --git a/pkg/snclient/listen_prometheus.go b/pkg/snclient/listen_prometheus.go index e361ff0b2..a94519a4c 100644 --- a/pkg/snclient/listen_prometheus.go +++ b/pkg/snclient/listen_prometheus.go @@ -17,7 +17,7 @@ func init() { ConfigInit{ ConfigData{ "port": "9999", - "use ssl": "0", + "use ssl": "true", }, "/settings/default", DefaultListenHTTPConfig, From 2d8af655ab9dff1b4bab56559fdc2f43e3d1dc61 Mon Sep 17 00:00:00 2001 From: lorenzg Date: Fri, 20 Nov 2026 15:36:51 +0100 Subject: [PATCH 2/5] add tests for defaults --- pkg/snclient/config.go | 70 +++++++++++---- pkg/snclient/config_test.go | 96 +++++++++++++++++++-- pkg/snclient/listen_exporterexporter.go | 11 ++- pkg/snclient/task_process_memory_watcher.go | 5 +- 4 files changed, 152 insertions(+), 30 deletions(-) diff --git a/pkg/snclient/config.go b/pkg/snclient/config.go index d5c371afa..15c2a63c1 100644 --- a/pkg/snclient/config.go +++ b/pkg/snclient/config.go @@ -43,25 +43,32 @@ const ( var DefaultConfig = map[string]ConfigData{ "/modules": { - "Logrotate": "enabled", - "ProcessMemoryWatcher": "enabled", - "CheckSystem": "enabled", - "CheckSystemUnix": "enabled", - "CheckAlias": "enabled", - "CheckMulti": "enabled", - "CheckExternalScripts": "disabled", - "CheckDisk": "enabled", - "CheckDriveIO": "enabled", - "CheckSwapIO": "enabled", - "CheckWMI": "disabled", - "CheckLogFile": "disabled", - "NRPEServer": "disabled", - "WEBServer": "enabled", - "PrometheusServer": "disabled", - "Updates": "enabled", + "Logrotate": "enabled", + "ProcessMemoryWatcher": "enabled", + "CheckSystem": "enabled", + "CheckSystemUnix": "enabled", + "CheckAlias": "enabled", + "CheckMulti": "enabled", + "CheckExternalScripts": "disabled", + "CheckDisk": "enabled", + "CheckDriveIO": "enabled", + "CheckSwapIO": "enabled", + "CheckWMI": "disabled", + "CheckLogFile": "disabled", + "CheckBuiltinPlugins": "disabled", + "NRPEServer": "disabled", + "WEBServer": "enabled", + "WEBAdminServer": "disabled", + "PrometheusServer": "disabled", + "NodeExporterServer": "disabled", + "WindowsExporterServer": "disabled", + "ExporterExporterServer": "disabled", + "ManagedExporterServer": "disabled", + "Updates": "enabled", }, "/settings/default": { - "nasty characters": DefaultNastyCharacters, + "nasty characters": DefaultNastyCharacters, + "allow control characters": "false", }, "/settings/wmi": { // number of WMI queries that may run in parallel; <= 1 uses the default client @@ -74,6 +81,30 @@ var DefaultConfig = map[string]ConfigData{ "stable": "https://api.github.com/repos/ConSol-monitoring/snclient/releases", "dev": "https://api.github.com/repos/ConSol-monitoring/snclient/actions/artifacts", }, + "/settings/check/files": { + "max files limit": strconv.Itoa(CheckFilesMaxFilesLimit), + }, + "/settings/check/logfile": { + "max lines per file limit": strconv.Itoa(maxLinesPerFileMax), + }, + "/settings/check/multi": { + "max checks": strconv.Itoa(defaultMaxChecks), + }, + "/settings/builtin plugins/default": { + "disabled": "false", + }, + "/settings/external scripts/alias/default": { + "ignore perfdata": "false", + "command": "", + }, + "/settings/external scripts/scripts/default": { + "ignore perfdata": "false", + "command": "", + }, + "/settings/log": { + "level": "info", + }, + "/settings/system/default": {}, "/settings/external scripts": { "timeout": "60", "script root": "${scripts}", // root path of all scripts @@ -122,6 +153,11 @@ var DefaultHTTPClientConfig = ConfigData{ func init() { // HTTP inherits TCP defaults DefaultListenHTTPConfig.Merge(DefaultListenTCPConfig) + defaultSettings := DefaultConfig["/settings/default"] + defaultSettings.Merge(DefaultListenHTTPConfig) + defaultSettings.Merge(DefaultHTTPClientConfig) + systemSettings := DefaultConfig["/settings/system/default"] + systemSettings.Merge(DefaultSystemTaskConfig) } type ConfigFiles []string diff --git a/pkg/snclient/config_test.go b/pkg/snclient/config_test.go index 1a1036086..f97bf5c00 100644 --- a/pkg/snclient/config_test.go +++ b/pkg/snclient/config_test.go @@ -6,25 +6,107 @@ import ( "os" "path/filepath" "runtime" + "strconv" "strings" "testing" "time" + "github.com/consol-monitoring/snclient/pkg/convert" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" ) func TestConfigPkgDefaults(t *testing.T) { - cfg := NewConfig(true) - err := cfg.ParseINIFile("../../packaging/snclient.ini", nil) + cfg := NewConfig(false) + require.NoError(t, cfg.ParseINIFile("../../packaging/snclient.ini", nil)) + + defaults := NewConfig(false) + for name, data := range DefaultConfig { + defaults.Section(name).MergeData(data) + } + defaults.ApplyMergeDefaultsAll(moduleConfigDefaults) + + // Resolve shared path macros equally without testing platform-specific installation paths. + defaults.Section("/paths").MergeData(cfg.Section("/paths").data) + + exceptions := map[string]string{ + "/paths/exe-path": "Detected from the executable.", + "/paths/shared-path": "Depends on the installation platform.", + "/paths/scripts": "Depends on the installation platform.", + "/paths/certificate-path": "Depends on the installation platform.", + "/paths/cache-path": "Uses the environment or system temporary folder.", + "/settings/log/file name": "The package enables file logging.", + "/settings/check/logfile/allowed pattern": "The package permits specific log paths.", + "/includes/local": "The package loads local configuration files.", + } + for _, name := range cfg.SectionNamesSorted() { + section := cfg.Section(name) + keys := append([]string(nil), section.Keys()...) + for _, key := range defaults.Section(name).Keys() { + if section.HasKey(key) { + continue + } + if _, ok := section.GetString(key); ok { + keys = append(keys, key) + } + } + for _, key := range keys { + t.Run(name+"/"+key, func(t *testing.T) { + if reason, ok := exceptions[name+"/"+key]; ok { + t.Log(reason) + + return + } + want := configPkgDefaultValue(t, section, key) + candidate := defaults.Section(name) + found := candidate.HasKey(key) + if key == "password" { + found = candidate.HasKey(key) + } + require.True(t, found, "[%s] %s has no code default or path exception", name, key) + actual := configPkgDefaultValue(t, candidate, key) + assert.Equal(t, want, actual, "[%s] %s: code default differs from packaging/snclient.ini", name, key) + }) + } + } - // verify default nasty characters nastyChars, _ := cfg.Section("/settings/WEB/server").GetString("nasty characters") - assert.Equalf(t, DefaultNastyCharacters, nastyChars, "default nasty characters") - assert.Containsf(t, nastyChars, "\\", "nasty characters contains backslash") - assert.Containsf(t, nastyChars, ";", "nasty characters contains semicolon") + assert.Equal(t, DefaultNastyCharacters, nastyChars) + assert.Contains(t, nastyChars, "\\") + assert.Contains(t, nastyChars, ";") +} - require.NoErrorf(t, err, "config parsed") +func configPkgDefaultValue(t *testing.T, section *ConfigSection, key string) string { + t.Helper() + + value, _ := section.GetString(key) + boolean := section.name == "/modules" + switch key { + case "password": + return section.data[key] + case "allowed hosts": + hosts, _ := section.GetStringList(key) + for index, host := range hosts { + hosts[index] = strings.Trim(host, "[]") + } + + return strings.Join(hosts, ",") + case "bat": + return strings.ReplaceAll(value, `\\`, `\`) + case "cache allowed hosts", "use ssl", "require password", "use hsts header", + "insecure", "allow arguments", "allow nasty characters", "allow control characters", + "ignore perfdata", "disabled", "modules dir watcher", "kill orphaned", + "automatic updates", "automatic restart", "pre release", "ProcessMemoryWatcher": + boolean = true + } + if boolean { + boolean, err := convert.BoolE(value) + require.NoError(t, err) + + return strconv.FormatBool(boolean) + } + + return value } func TestConfigBasic(t *testing.T) { diff --git a/pkg/snclient/listen_exporterexporter.go b/pkg/snclient/listen_exporterexporter.go index 84f00cbf6..98be6a3b3 100644 --- a/pkg/snclient/listen_exporterexporter.go +++ b/pkg/snclient/listen_exporterexporter.go @@ -34,10 +34,13 @@ func init() { NewHandlerExporterExporter, ConfigInit{ ConfigData{ - "port": "${/settings/WEB/server/port}", - "use ssl": "${/settings/WEB/server/use ssl}", - "url prefix": "/", - "modules dir": "${shared-path}/exporter_modules", + "port": "${/settings/WEB/server/port}", + "use ssl": "${/settings/WEB/server/use ssl}", + "url prefix": "/", + "modules dir": "${shared-path}/exporter_modules", + "modules dir watcher": "false", + "default module": "", + "allowed methods": "", }, "/settings/default", DefaultListenHTTPConfig, diff --git a/pkg/snclient/task_process_memory_watcher.go b/pkg/snclient/task_process_memory_watcher.go index ed1c7a38c..f41ffb6bc 100644 --- a/pkg/snclient/task_process_memory_watcher.go +++ b/pkg/snclient/task_process_memory_watcher.go @@ -20,8 +20,9 @@ func init() { NewProcessMemoryWatcherHandler, ConfigInit{ ConfigData{ - "check interval": "5s", - "memory limit": "512MiB", + "check interval": "5s", + "memory limit": "512MiB", + "ProcessMemoryWatcher": "enabled", }, }, ) From 21c00db1077dbc9a1d9c526d95c51bdf058c18a2 Mon Sep 17 00:00:00 2001 From: lorenzg Date: Fri, 20 Nov 2026 15:46:48 +0100 Subject: [PATCH 3/5] rm obsolete nastychar test --- pkg/snclient/config_test.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/pkg/snclient/config_test.go b/pkg/snclient/config_test.go index f97bf5c00..5cd3321e0 100644 --- a/pkg/snclient/config_test.go +++ b/pkg/snclient/config_test.go @@ -69,11 +69,6 @@ func TestConfigPkgDefaults(t *testing.T) { }) } } - - nastyChars, _ := cfg.Section("/settings/WEB/server").GetString("nasty characters") - assert.Equal(t, DefaultNastyCharacters, nastyChars) - assert.Contains(t, nastyChars, "\\") - assert.Contains(t, nastyChars, ";") } func configPkgDefaultValue(t *testing.T, section *ConfigSection, key string) string { From 84d54f7252f5d527d7a3e03a775429d4d42e8390 Mon Sep 17 00:00:00 2001 From: lorenzg Date: Fri, 20 Nov 2026 16:26:34 +0100 Subject: [PATCH 4/5] replace strconv with sprintf --- pkg/snclient/config.go | 6 +++--- pkg/snclient/config_test.go | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/pkg/snclient/config.go b/pkg/snclient/config.go index 15c2a63c1..c2d101c5e 100644 --- a/pkg/snclient/config.go +++ b/pkg/snclient/config.go @@ -82,13 +82,13 @@ var DefaultConfig = map[string]ConfigData{ "dev": "https://api.github.com/repos/ConSol-monitoring/snclient/actions/artifacts", }, "/settings/check/files": { - "max files limit": strconv.Itoa(CheckFilesMaxFilesLimit), + "max files limit": fmt.Sprintf("%d", CheckFilesMaxFilesLimit), }, "/settings/check/logfile": { - "max lines per file limit": strconv.Itoa(maxLinesPerFileMax), + "max lines per file limit": fmt.Sprintf("%d", maxLinesPerFileMax), }, "/settings/check/multi": { - "max checks": strconv.Itoa(defaultMaxChecks), + "max checks": fmt.Sprintf("%d", defaultMaxChecks), }, "/settings/builtin plugins/default": { "disabled": "false", diff --git a/pkg/snclient/config_test.go b/pkg/snclient/config_test.go index 5cd3321e0..55c52f681 100644 --- a/pkg/snclient/config_test.go +++ b/pkg/snclient/config_test.go @@ -6,7 +6,6 @@ import ( "os" "path/filepath" "runtime" - "strconv" "strings" "testing" "time" @@ -98,7 +97,7 @@ func configPkgDefaultValue(t *testing.T, section *ConfigSection, key string) str boolean, err := convert.BoolE(value) require.NoError(t, err) - return strconv.FormatBool(boolean) + return fmt.Sprintf("%t", boolean) } return value From 784c0ea6bb3c3a3d4fcd69154eec3d1f7e422e3a Mon Sep 17 00:00:00 2001 From: lorenzg Date: Fri, 20 Nov 2026 16:42:54 +0100 Subject: [PATCH 5/5] apply defaults after config files and includes are parsed --- pkg/snclient/config.go | 5 ----- pkg/snclient/config_test.go | 3 +++ pkg/snclient/snclient.go | 4 ++++ 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/pkg/snclient/config.go b/pkg/snclient/config.go index c2d101c5e..f4f076659 100644 --- a/pkg/snclient/config.go +++ b/pkg/snclient/config.go @@ -153,11 +153,6 @@ var DefaultHTTPClientConfig = ConfigData{ func init() { // HTTP inherits TCP defaults DefaultListenHTTPConfig.Merge(DefaultListenTCPConfig) - defaultSettings := DefaultConfig["/settings/default"] - defaultSettings.Merge(DefaultListenHTTPConfig) - defaultSettings.Merge(DefaultHTTPClientConfig) - systemSettings := DefaultConfig["/settings/system/default"] - systemSettings.Merge(DefaultSystemTaskConfig) } type ConfigFiles []string diff --git a/pkg/snclient/config_test.go b/pkg/snclient/config_test.go index 55c52f681..62d107a44 100644 --- a/pkg/snclient/config_test.go +++ b/pkg/snclient/config_test.go @@ -23,6 +23,9 @@ func TestConfigPkgDefaults(t *testing.T) { for name, data := range DefaultConfig { defaults.Section(name).MergeData(data) } + defaults.Section("/settings/default").MergeData(DefaultListenHTTPConfig) + defaults.Section("/settings/default").MergeData(DefaultHTTPClientConfig) + defaults.Section("/settings/system/default").MergeData(DefaultSystemTaskConfig) defaults.ApplyMergeDefaultsAll(moduleConfigDefaults) // Resolve shared path macros equally without testing platform-specific installation paths. diff --git a/pkg/snclient/snclient.go b/pkg/snclient/snclient.go index 70809745d..52cf6579f 100644 --- a/pkg/snclient/snclient.go +++ b/pkg/snclient/snclient.go @@ -611,6 +611,10 @@ func (snc *Agent) ReadConfiguration(files []string) (initSet *AgentRunSet, err e section.MergeData(defaults) } + config.Section("/settings/default").MergeData(DefaultListenHTTPConfig) + config.Section("/settings/default").MergeData(DefaultHTTPClientConfig) + config.Section("/settings/system/default").MergeData(DefaultSystemTaskConfig) + // apply module defaults config.ApplyMergeDefaultsAll(moduleConfigDefaults)